List of unused columns/tables in the database structure: Difference between revisions
Wolfganguhr (talk | contribs) |
|||
| Line 12: | Line 12: | ||
* '''a_transaction.a_debit_credit_indicator_l''': The name is mistakable. The name a_transaction.a_is_debit_indicator_l may be something more clear. | * '''a_transaction.a_debit_credit_indicator_l''': The name is mistakable. The name a_transaction.a_is_debit_indicator_l may be something more clear. | ||
* '''a_recurring_gift_detail.a_gift_amount_n''' should be renamed to '''a_gift_transaction_amount_n''', to reflect that this amount is in the transaction currency. In analogy to a_gift_detail, a_gift_amount_n is the amount in base currency | * '''a_recurring_gift_detail.a_gift_amount_n''' should be renamed to '''a_gift_transaction_amount_n''', to reflect that this amount is in the transaction currency. In analogy to a_gift_detail, a_gift_amount_n is the amount in base currency | ||
== Decision necessary == | |||
=== a_ledger.a_year_end_flag_l and a_ledger.a_provisional_year_end_flag_l === | |||
Actually the columns a_ledger.a_year_end_flag_l and a_ledger.a_provisional_year_end_flag_l seems to be the boolean inverse of each other. | |||
They are set in GL3240.p Line 849 and 850 to | |||
a_ledger.a_year_end_flag_l = TRUE | |||
a_ledger.a_provisional_year_end_flag_l = FALSE | |||
and reset in GL4200.p Line 736 and 737 | |||
The lines 885 and 886 are part of an obsolete code. | |||
The parameter a_ledger.a_year_end_flag_l is only used one time in gl3240.p line 284 and the other parameter is used more than 10 times. Some appearences are in a comment and some in an obsolete code. So 21 hits - 3 assignments is not quite correct. I think that the sligt difference of the parameters only has been availiable in older petra versions and the parameters history will give a better answer to keep or to skip the parameter. | |||
Actually I use it in my code as it was used in petra. | |||
Revision as of 08:44, 6 April 2011
This is a list of columns or even tables in petra.xml, that should be removed, because they are not used.
Please always add a comment, whether or where it has been used in the old Progress code.
- a_accounting_period.a_effective_date_d: Only used in the setup screen for the accounting periods, progress\petra\finance\glsetup\gs1014p.p
- a_ledger.a_current_accounting_period_i: deprecated; not used at the moment; please use a_current_period_i
- a_ledger.a_periods_per_financial_year_i: deprecated; not used at the moment; please use a_number_of_accounting_periods_i
List of names which shall be changed something
- a_transaction.a_debit_credit_indicator_l: The name is mistakable. The name a_transaction.a_is_debit_indicator_l may be something more clear.
- a_recurring_gift_detail.a_gift_amount_n should be renamed to a_gift_transaction_amount_n, to reflect that this amount is in the transaction currency. In analogy to a_gift_detail, a_gift_amount_n is the amount in base currency
Decision necessary
a_ledger.a_year_end_flag_l and a_ledger.a_provisional_year_end_flag_l
Actually the columns a_ledger.a_year_end_flag_l and a_ledger.a_provisional_year_end_flag_l seems to be the boolean inverse of each other.
They are set in GL3240.p Line 849 and 850 to
a_ledger.a_year_end_flag_l = TRUE a_ledger.a_provisional_year_end_flag_l = FALSE
and reset in GL4200.p Line 736 and 737
The lines 885 and 886 are part of an obsolete code.
The parameter a_ledger.a_year_end_flag_l is only used one time in gl3240.p line 284 and the other parameter is used more than 10 times. Some appearences are in a comment and some in an obsolete code. So 21 hits - 3 assignments is not quite correct. I think that the sligt difference of the parameters only has been availiable in older petra versions and the parameters history will give a better answer to keep or to skip the parameter.
Actually I use it in my code as it was used in petra.